ScummVM 0.7.1 testing begins

[Arisme]

[d0pefish]

[Arisme]

[d0pefish]

[Arisme]

[iankay]

[Arisme]

[TDO]

Smartphone

First impression, looks great.

Just the textline between grafik and commandsection is a little bit hard to read. (it looks like one or two lines are missing)

Just browsed a bit through the source code and I am just curious.

Why are you using for the smartphone the following scalefactors:

_scaleFactorXm = 2;
_scaleFactorXd = 3;

and not

_scaleFactorXm = 11;
_scaleFactorXd = 16;

as this would give exactly 220 pixels?

If you keep the factors 2 and 3 could you use an offset of 3 to center the picture? (now there is at the right a black area)

[Arisme]

[Arisme]

[vejur79]

[Arisme]

[twins73]

Hi Arisme,

Just one little things, while checking your site
for the latest CVS version, I saw some tidbits
about CEScaler.cpp and got curious.

One tiny little thing just in case, in
CEinterpolate16_4 you do a division by 4,
and the old ASM 86 geek in me was wondering
why you are not shifting bits right by 2
(A >> 4)

Also, in PocketPCPortrait you call
CEinterpolate16_2 with fix constants (3, 1).
Then inside CEinterpolate16_2 you do a
& redblueMasks[maskUsed] and a
& & greenMasks[maskUsed] on those fix values.
Would not it be most efficient to do the
calculations outside of CEinterpolate16_2
for those fix values ? (do it once for all
before while (height--)

Well sorry for bothering, just wanted to help
since you make all of us more than happy to
play ours old lucasarts games on ours pocketpcs

Thanks

[Twins73]

Ahem, I meant right shifting bits by 2
for dividing by 4 as in (A >> 2) I mistyped.

[enjoy]